Update to MYNN-EDMF to add re-indexed arrays and temperature tendency change #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderrico-noaa
requested review from
barlage,
haiqinli,
tanyasmirnova,
mdtoyNOAA,
AndersJensen-NOAA and
clark-evans
clark-evans
reviewed
Feb 21, 2025
mdtoyNOAA
approved these changes
Feb 21, 2025
|
I'm sure it will pass the test. :) |
clark-evans
approved these changes
Mar 17, 2025
tanyasmirnova
approved these changes
Mar 18, 2025
haiqinli
approved these changes
Mar 18, 2025
AndersJensen-NOAA
requested changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of the changes in this PR are to re-index some arrays in the mass-flux component. Variables at the interface are indexed from kts to kte+1 where kts is the surface. Variables at the mass layers are kts to kte. Before this PR, some of these arrays were used inconsistently. The inconsistencies were known, so it did cause a problem, but it always bothered me. After the cleanup, the results are practically identical, as expected. It can not be bit-for-bit identical due to some vertical interpolations.
There is one additional change to the temperature tendency calculation, which should have a small impact, but it may impact upper-level RH enough to deserve system testing in advance of HWT. MPAS-Dev2 testing shows very small impacts overall from this modification.
A second part of this PR includes a TKE-dependent lateral entrainment for the mass-flux scheme. This seemingly has a small impact over land, but significantly improves the mass-flux activity over water. Changes to CONUS stats are expected to be very minor.
Information on running mandatory regression tests on Jet can be found here and the results pasted below.
regression test case results