V8.2.2-2.8 - Bug fixes in seaice treatment when frac_seaice=false. and with RUC ice model. #97
Conversation
1. Fix the bug that crashes MPAS when frac_seaice=false. Use 'if(config_frac_seaice) then' around arrays with *_sea that are allocated only when config_frac_seaice=true. This bug is reported to Michael Duda. 2. Add flqc and flhc computation for fractional ice. These variables are used in RUC ice module and are needed for reproducibility over sea ice.
1. Do not deallocate flqc_sea and flhc_sea - they are used later in the seaice driver.
xice=1. It will reduce computations over solid sea ice (Arctic).
CPM is not RUC-specific variable, moved out of sf_ruc IF.
…into seaice_fix
tanyasmirnova
changed the title
jderrico-noaa
requested review from
barlage,
joeolson42,
haiqinli,
mdtoyNOAA,
AndersJensen-NOAA and
clark-evans
There was a problem hiding this comment.
@tanyasmirnova - though I don't see any issues with reproducibility in the test results you've provided, I'm wondering if the changes in module_sf_sfcdiags_ruclsm.F (two added commented integers, two added print statements) are necessary?
Otherwise, once the code base is updated to 8.2.2-2.7 (I'm seeing a message at the bottom of the PR that it's not at the current version, which makes sense given Janet's merging of PR #70 today), this looks good to me.
@clark-evans Clark, I added some debug prints to module_sf_sfcdiags_ruclsm.F which is used only with RUC LSM. It is nice to have these additional prints in there when we want to debug the ice points. |
background albedo when water is frozen.
lines for easy merge with NCAR code.
In the LSM driver frpcpn = false. If it is false, frozen precipitation in RUC and Noah LSMs is computed using temperature threshold and ignoring the information from the microphysics scheme. A new parameter frpcpn_ruc is introduced for use with RUC LSM, and it is set to true. This change will use the microphysics information correctly and will fix the problem with the run-total accumulation of snow depth.
The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).
Enter a description of this PR. This should include why this PR was created, and what it does.
The changes are:
mpas_atmphys_driver_seaice.F
'if(config_frac_seaice) then' around arrays with *_sea that are
allocated only when config_frac_seaice=true. This bug is reported to
Michael Duda, PR is created in NCAR MPAS.
used in RUC ice module and are needed for reproducibility over sea ice.
mpas_atmphys_driver_sfclayer.F:
the seaice driver.
covered with sea ice (Arctic).
Testing and relations to other Pull Requests should be added as subsequent comments.
See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931
Information on running mandatory regression tests on Jet can be found here and the results pasted below.
Preliminary Regression TESTS:
The file is in:
/mnt/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/utils/compare_run_testcases_v8.2.2-2.8-intdebug
regression test case results