Modifications for DAcycling=true #136

tanyasmirnova · 2025-05-28T18:20:50Z

The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).

Enter a description of this PR. This should include why this PR was created, and what it does.

Testing and relations to other Pull Requests should be added as subsequent comments.

See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931

Information on running mandatory regression tests on Jet can be found here and the results pasted below.

regression test case results

PASTE compare_run_testcases AND/OR compare_create_testcases TEXT HERE

 version_to_compare = v8.2.2-3.12

gsl_version_baseline = v8.2.2-3.11
ncar_version_baseline = v8.2.2
test_directory = /lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/
gsl_baseline_directory = /lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/
ncar_baseline_directory = /lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/
compile_flag = -intdebug
test_repo_name = gsl

######################################################################

compare to previous GSL CONUS mesoscale_reference baselines A1GSL

######################################################################

=== history.2023-03-10_15.00.00.nc comparison
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.mesoscale_reference.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.00.00.nc" and "/lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/gsl-v8.2.2-3.11-intdebug.mesoscale_reference.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.00.00.nc" are identical.

=== history.2023-03-10_15.12.00.nc comparison
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.mesoscale_reference.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.12.00.nc" and "/lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/gsl-v8.2.2-3.11-intdebug.mesoscale_reference.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.12.00.nc" are identical.

=== history.2023-03-10_16.00.00.nc comparison
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.mesoscale_reference.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_16.00.00.nc" and "/lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/gsl-v8.2.2-3.11-intdebug.mesoscale_reference.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_16.00.00.nc" are identical.

#############################################################################

compare to previous GSL CONUS convection_permitting_none baselines F1GSL

#############################################################################

=== history.2023-03-10_15.00.00.nc comparison
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.convection_permitting_none.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.00.00.nc" and "/lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/gsl-v8.2.2-3.11-intdebug.convection_permitting_none.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.00.00.nc" are identical.

=== history.2023-03-10_15.12.00.nc comparison
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.co
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.convection_permitting_none.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.12.00.nc" and "/lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/gsl-v8.2.2-3.11-intdebug.convection_permitting_none.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.12.00.nc" are identical.

=== history.2023-03-10_16.00.00.nc comparison
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.convection_permitting_none.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_16.00.00.nc" and "/lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/gsl-v8.2.2-3.11-intdebug.convection_permitting_none.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_16.00.00.nc" are identical.

########################################################################

compare to previous NCAR CONUS mesoscale_reference baselines A1NCAR

########################################################################

=== history.2023-03-10_15.00.00.nc comparison
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.mesoscale_reference.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.00.00.nc" and "/lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/ncar-v8.2.2-intdebug.mesoscale_reference.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.00.00.nc" are identical.

=== history.2023-03-10_15.12.00.nc comparison
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.mesoscale_reference.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.12.00.nc" and "/lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/ncar-v8.2.2-intdebug.mesoscale_reference.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.12.00.nc" are identical.

=== history.2023-03-10_16.00.00.nc comparison
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.mesoscale_reference.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_16.00.00.nc" and "/lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/ncar-v8.2.2-intdebug.mesoscale_reference.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_16.00.00.nc" are identical.

###############################################################################

compare to previous NCAR CONUS convection_permitting_none baselines F1NCAR

###############################################################################

=== history.2023-03-10_15.00.00.nc comparison
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.convection_permitting_none.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.00.00.nc" and "/lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/ncar-v8.2.2-intdebug.convection_permitting_none.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.00.00.nc" are identical.

=== history.2023-03-10_15.12.00.nc comparison
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.convection_permitting_none.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.12.00.nc" and "/lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/ncar-v8.2.2-intdebug.convection_permitting_none.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_15.12.00.nc" are identical.

=== history.2023-03-10_16.00.00.nc comparison
Files "/lfs5/BMC/wrfruc/smirnova/MPAS_regression_tests/mpas_testcase/run_case/gsl-v8.2.2-3.12-intdebug.convection_permitting_none.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_16.00.00.nc" and "/lfs5/BMC/wrfruc/Michael.Barlage/mpas/baselines_mpas/run_case/ncar-v8.2.2-intdebug.convection_permitting_none.ncar.ncar.conus.120km.gfs.2023031015/history.2023-03-10_16.00.00.nc" are identical.

guoqing-noaa · 2025-05-29T01:01:08Z

src/core_atmosphere/physics/mpas_atmphys_init.F

@@ -308,7 +310,7 @@ subroutine physics_init(dminfo,stream_manager,clock,configs,mesh,diag,tend,state
 endif

 !initialization of xicem:
- if(.not.config_do_restart) then
+ if(.not.config_do_restart .or. .not.config_do_DAcycling) then


@tanyasmirnova Should it be

if(.not.config_do_restart .and. .not.config_do_DAcycling)

at lines 313 and 321?

guoqing-noaa · 2025-05-29T01:03:16Z

src/core_atmosphere/physics/mpas_atmphys_lsm_rucinit.F

@@ -172,7 +174,7 @@ subroutine ruclsminit(dminfo,mesh,configs,diag_physics,sfc_input)
 call mpas_log_write('')


-if(.not.restart) then
+if(.not.restart .or. .not. cycling) then


Should it be "if not restart and not cycling"?
ie.

if(.not.restart .and. .not. cycling) then

guoqing-noaa · 2025-05-29T16:15:20Z

src/core_atmosphere/physics/physics_wrf/module_mynnsfclay_driver.F90

@@ -194,7 +194,8 @@ subroutine mynnsfclay_driver(                                   &
 integer,intent(in):: ids,ide,jds,jde,kds,kde, &
                      ims,ime,jms,jme,kms,kme, &
                      its,ite,jts,jte,kts,kte
- integer,intent(in):: itimestep
+ logical,intent(in):: restart,DAcycling


One cosmetic comment:
since restart and cycling are used in a few files in the above, to be consistent, we may want to change DAcycling here to cycling.

The change is made.

requested by the reviewer.

corrected to do initialization only for cold-start runs.

src/core_atmosphere/physics/physics_wrf/module_mynnsfclay.F90

guoqing-noaa · 2025-05-30T03:02:34Z

@tanyasmirnova
It looks like the following files also contain "config_do_restart" but don't have the "config_do_DAcycling" logic:

core_atmosphere/physics/mpas_atmphys_control.F
core_atmosphere/physics/mpas_atmphys_driver_convection.F
core_atmosphere/physics/mpas_atmphys_driver_pbl.F
core_atmosphere/physics/mpas_atmphys_lsm_noahinit.F
core_atmosphere/physics/mpas_atmphys_driver_lsm_noahmp.F
core_atmosphere/physics/mpas_atmphys_lsm_noahmpinit.F
core_atmosphere/physics/mpas_atmphys_driver_microphysics.F

tanyasmirnova · 2025-05-30T15:39:58Z

Guoq

@tanyasmirnova It looks like the following files also contain "config_do_restart" but don't have the "config_do_DAcycling" logic:

core_atmosphere/physics/mpas_atmphys_control.F
core_atmosphere/physics/mpas_atmphys_driver_convection.F
core_atmosphere/physics/mpas_atmphys_driver_pbl.F
core_atmosphere/physics/mpas_atmphys_lsm_noahinit.F
core_atmosphere/physics/mpas_atmphys_driver_lsm_noahmp.F
core_atmosphere/physics/mpas_atmphys_lsm_noahmpinit.F
core_atmosphere/physics/mpas_atmphys_driver_microphysics.F

The core_atmosphere/physics/mpas_atmphys_control.F is simply specifying the levels/layers in soil domain. It will not hurt to do it in the cycling run.
Other physics developers should take care of the rest subroutines in your list: @joeolson42 @haiqinli @barlage @AndersJensen-NOAA

guoqing-noaa · 2025-05-30T15:59:07Z

src/core_atmosphere/physics/mpas_atmphys_driver_sfclayer.F

@@ -1193,7 +1195,7 @@ subroutine driver_sfclayer(itimestep,configs,mesh,diag_physics,sfc_input,its,ite
 dx = sqrt(maxval(areaCell))

 initflag = 1
- if(config_do_restart .or. itimestep > 1) initflag = 0
+ if(config_do_restart .or. config_do_DAcycling .or. itimestep > 1) initflag = 0


@tanyasmirnova Could you help me understand what initflag means?
0 means init from cold start? 1 means init from warm start? Thanks!

initflag = 1 for cold-start, and initflag=0 for restart and DAcycling.

Got it. Thanks!

'input' stream when configure_do_DAcycling=true. Also, a change to avoid writing out mpasout* at initial time not to overwrite the analysis file.

guoqing-noaa · 2025-05-30T21:36:52Z

src/core_atmosphere/mpas_atm_core.F

@@ -642,6 +646,8 @@ function atm_core_run(domain) result(ierr)

      ! Avoid writing a restart file at the initial time
      call MPAS_stream_mgr_reset_alarms(domain % streamManager, streamID='restart', direction=MPAS_STREAM_OUTPUT, ierr=ierr)
+      ! Avoid writing a mpasout file at the initial time
+      call MPAS_stream_mgr_reset_alarms(domain % streamManager, streamID='da_state', direction=MPAS_STREAM_OUTPUT, ierr=ierr)


Will Line 650 complain if streams.atmosphere does not define da_state?

Since da_state only applies to DAcycling, maybe we can add an if block here?

if (config_do_DAcycling) then call MPAS_stream_mgr_reset_alarms(domain % streamManager, streamID='da_state', direction=MPAS_STREAM_OUTPUT, ierr=ierr) end if

I jut copied what they do for restart, there is no 'if (restart) around it.

Good point. Then I think it is fine. Thanks!

barlage · 2025-06-02T13:37:06Z

src/core_atmosphere/mpas_atm_core.F

@@ -137,6 +139,8 @@ function atm_core_init(domain, startTimeStamp) result(ierr)
      call mpas_timer_start('read_ICs')
      if (config_do_restart) then
         init_stream_name = 'restart'
+      elseif (config_do_DAcycling) then
+         init_stream_name = 'da_state'


does there need to be an alarm reset like init/restart on lines 163/164 added below line 164?

Agree with @barlage . We need to add one line after line 164 as follows:
call MPAS_stream_mgr_reset_alarms(domain % streamManager, streamID='da_state', direction=MPAS_STREAM_INPUT, ierr=ierr)

The line to reset the alarm for da_state is added.

tanyasmirnova added 5 commits May 22, 2025 20:31

Merged DA cycling changes into 3.11 version

a6a902a

Changes in MYNN surface layer scheme for DAcycling=true.

bc43ecd

Removed physics_lsm_ruc because RUC LSM is in submodule.

524a6b5

Removed binary files

b846153

Restore some subroutines to the original

bba5416

guoqing-noaa reviewed May 29, 2025

View reviewed changes

tanyasmirnova added 4 commits May 29, 2025 16:44

DAcycling is changed to cycling for consistency.

3b8f02d

In mpas_atmphys_driver_sfclayer.F DAcycling is changed to cycling as

e2e0327

requested by the reviewer.

In mpas_atmphys_landuse.F and mpas_atmphys_init.F, the logic is

16c974f

corrected to do initialization only for cold-start runs.

Fixed the logic for DAcycling in mpas_atmphys_lsm_rucinit.F

2bb18fe

guoqing-noaa reviewed May 30, 2025

View reviewed changes

src/core_atmosphere/physics/physics_wrf/module_mynnsfclay.F90 Show resolved Hide resolved

guoqing-noaa reviewed May 30, 2025

View reviewed changes

The change in mpas_atm_core.F to read the 'da_state' stream rather than

fbdcecf

'input' stream when configure_do_DAcycling=true. Also, a change to avoid writing out mpasout* at initial time not to overwrite the analysis file.

guoqing-noaa reviewed May 30, 2025

View reviewed changes

barlage reviewed Jun 2, 2025

View reviewed changes

barlage mentioned this pull request Jun 2, 2025

cold start and warm start use different streams to read MPAS initial conditions NOAA-EMC/rrfs-workflow#812

Open

Added alarm reset for 'da_state' input stream.

04871d3

tanyasmirnova marked this pull request as ready for review June 2, 2025 21:52

tanyasmirnova requested review from jderrico-noaa and clark-evans as code owners June 2, 2025 21:52

clark-evans requested review from barlage, joeolson42, haiqinli, mdtoyNOAA and AndersJensen-NOAA June 2, 2025 23:50

Modifications for DAcycling=true #136

Are you sure you want to change the base?

Modifications for DAcycling=true #136

Uh oh!

Conversation

tanyasmirnova commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

compare to previous GSL CONUS mesoscale_reference baselines A1GSL

compare to previous GSL CONUS convection_permitting_none baselines F1GSL

compare to previous NCAR CONUS mesoscale_reference baselines A1NCAR

compare to previous NCAR CONUS convection_permitting_none baselines F1NCAR

Uh oh!

guoqing-noaa May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guoqing-noaa May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

guoqing-noaa commented May 30, 2025

Uh oh!

tanyasmirnova commented May 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

barlage Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tanyasmirnova commented May 28, 2025 •

edited

Loading

guoqing-noaa May 29, 2025 •

edited

Loading

guoqing-noaa May 29, 2025 •

edited

Loading

barlage Jun 2, 2025 •

edited

Loading