Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR extends file preview support to include additional archive formats beyond the existing zip and tar support. The change adds support for gzip, gtar, xz, and 7z compressed files.
Key changes:
- Expanded the
allowedPreviewFormatsarray to include 5 additional archive MIME types (gzip, gtar, xz, 7z) - Refactored
isArchive()method to use array indexing withallowedPreviewFormats.includes(format, 2)instead of explicit format checks
Comments suppressed due to low confidence (1)
src/app/item-page/simple/field-components/preview-section/file-description/file-description.component.ts:199
- The JSDoc comment for
couldPreview()is outdated. It only lists three formats (text/plain,text/html,application/zip), but theallowedPreviewFormatsarray now includes 8 formats. Update the documentation to reflect all supported preview formats or reference the constant instead of hardcoding the list.
/**
* Supported Preview formats are: `text/plain`, `text/html`, `application/zip`
*/
...-page/simple/field-components/preview-section/file-description/file-description.component.ts
Outdated
Show resolved
Hide resolved
6 tasks
Member
|
@kuchtiak-ufal |
Author
|
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended the File Preview feature for the following archive formats:
See how it works:
