Merged
Conversation
* fix the Composer cache directory * run jobs with different Symfony versions only on PHP 5.6 * drop jobs for Symfony versions that reached EOL * add job for PHP 7 * run code coverage reports only on PHP 7 * disable Xdebug when code coverage reports won't be generated * finish as soon as possible (when either a mandatory job failed or only jobs that are allowed to fail are running)
|
The inspection completed: 28 Issues, 1 Patches |
Contributor
|
Is it worth removing 2.6? Its EOLed in less than a month |
Contributor
|
by the time @kmfk merges this, it'll be EOLed ;) |
Contributor
|
@xabbuh - Thanks for this! I tried rebuilding your failed tests after merging #87 - but I still get the same error in Travis. There are also tests failing where we previously checked for Maybe create new tests for the correct exceptions and group them in PHPUnit so they can be ignored on the other tests - or use |
Contributor
|
Rebuilding this again, the YAML fix did actually work. I'm gonna merge this and fix the other tests in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jobs that are allowed to fail are running)