Replace deprecated unload
event with pagehide
event
#824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear hocuspocus folks,
I noticed that the
HocuspocusProvider
is using the deprecatedunload
event. MDN advises to use thepagehide
event instead, so this is what I chose to use for this PR. I searched for any open and closed issues and PRs that could be related to this and hence am aware of #658 and #657, where the previously usedbeforeunload
event was found to be problematic.I checked if the
pagehide
event also fires when starting a download as described in #657 and found that it in fact does not fire. Therefore I think this event might be a viable alternative tounload
.Cheers,
Julian