fix (Connection): Add error handler to websocket instance

[jamesopti]

Overview

Fixes #392

Adds a listener for the error event from the underlying ws instance.

This is necessary to handle any errors emitted by an individual websocket object are caught and don't cause the server to crash.

Context

websockets/ws#1825 (comment)

websockets/ws#1777 (comment)

[janthurau]

@jamesopti thanks a lot for your bug report and even more thanks for fixing it yourself!! 🙏

[janthurau]

@jamesopti Do we need to keep the updated package-json.lock? Looks like it was just generated by a new npm version probably?

[jamesopti]

@jamesopti Do we need to keep the updated package-json.lock? Looks like it was just generated by a new npm version probably?

Good catch, reverted!

How does this repo manage NPM versions? I'm using NVM and currently have 16.3 (.nvm/versions/node/v16.13.0/bin/node)

[jamesopti]

@janthurau Any ideas about the test failures here? https://github.com/ueberdosis/hocuspocus/runs/8094400524?check_suite_focus=true#step:7:555

Googling suggests this error was introduced in Node 18.6 but I think this repo runs Node 16 🤔

[janthurau]

@jamesopti thx! Seems like Github changed something, the tests that passed yesterday suddenly started failing as well (https://github.com/ueberdosis/hocuspocus/actions/runs/2944477556). Let's hope this resolves itself (on github side maybe), if not I'll have a look on Thursday/Friday. Weird!

[jamesopti]

@jamesopti thx! Seems like Github changed something, the tests that passed yesterday suddenly started failing as well (https://github.com/ueberdosis/hocuspocus/actions/runs/2944477556). Let's hope this resolves itself (on github side maybe), if not I'll have a look on Thursday/Friday. Weird!

Hmmm looks like the Node version changes since yesterday from 16.16 to 16.17 (see screenshots from successful vs unsuccessful builds of this PR).

I suspect we'll need to pin to node 16.16 or fix the errors. I can reproduce locally now with v16.17

[svenadlung]

Wow, yes. We fought with this several hours on local machines already.

See
TypeStrong/ts-node#1865 and
TypeStrong/ts-node#1839

Updating ts-node leads to another error.
See https://github.com/ueberdosis/hocuspocus/runs/8095091264?check_suite_focus=true

Most people changed from ts-node to esbuild-node-loader which seems to be deprecated. Using tsm instead results in problems with chalk in particular (lukeed/tsm#31).

Not really happy about it but pinning node version seems to be the only solution right now?

[janthurau]

I've updated the github actions to stick with 16.16 for now and rebased this branch with main. Let's pray for the build to succeed :)