This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding dbw_enable status change from the simulator's manual control button
spicavigo
suggested changes
Sep 1, 2017
ros/src/styx/server.py
Outdated
|
||
@sio.on('connect') | ||
def connect(sid, environ): | ||
print("connect ", sid) | ||
bridge.publish_dbw_status(True) | ||
bridge.publish_dbw_status(dbw_enable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line
ros/src/styx/server.py
Outdated
@@ -29,6 +30,10 @@ def send(topic, data): | |||
|
|||
@sio.on('telemetry') | |||
def telemetry(sid, data): | |||
global dbw_enable | |||
if(data["dbw_enable"] != dbw_enable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the parantheses
changed to hard coded False when starting, its False because car starts in manual mode and dbw_enable is false at that state. Removed the parenthesis
remove the unneeded line
lake4790k
pushed a commit
to lake4790k/CarND-Capstone
that referenced
this pull request
Jan 17, 2018
WIP: tl_detector fix missing position msg bug
samipshah
pushed a commit
to samipshah/CarND-Capstone
that referenced
this pull request
Jan 22, 2018
Waypoint updater full
dylanbrandtner
pushed a commit
to dylanbrandtner/CarND-Capstone
that referenced
this pull request
Apr 5, 2019
Fix index for traffic line
Verichev
pushed a commit
to Verichev/CarND-Capstone
that referenced
this pull request
Jul 16, 2019
Issue # 7: Create a shared_utils package for use by other packages
bwosh
pushed a commit
to bwosh/CarND-Capstone
that referenced
this pull request
Mar 19, 2020
Update Blazej's email to udacity email
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding dbw_enable status change from the simulator's manual control button