Avoid -fforce-recomp when benchmarking #2565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundominguez
force-pushed
the
fd/avoid-linking-with-fforce-recomp
branch
from
760c082 to
819abf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running benchmarks, we found a quirk in cabal that causes the link step to override the time measures collected during the build step.
To obtain useful measures in the end, we have been forcing the link step to rebuild modules with
-fforce-recompwhen running benchmarks. This duplicated the benchmark time, as modules were built twice, first in the build step, and a second time in the link step!This PR avoids the need for
-fforce-recompby instead collecting time measures only when the Liquid Haskell plugin runs. Since the plugin only runs in the build step, measures are not overwritten in the linking step anymore.