-
Notifications
You must be signed in to change notification settings - Fork 39
Strings Week8 Conflicts and New Features #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2022
Are you sure you want to change the base?
Conversation
…iler-B into type_checker
I've tried merging your feature and fixing some conflicts, but there's more work here to be done. Could you try fixing the issues with the tests and let me know how that goes. |
We'll start working on that as soon as possible! |
One smaller issue. Can you add .vscode to gitignore and delete the .vscode folder? It will make our lives a lot easier! |
I see 5 failings in your string tests, please take a look and try to resolve them. |
now all the string tests pass, but we encountered some other bugs due to interactions with other groups. We have reported via email to the teaching team and the related groups. |
Now merging does not introduce any new test fails. (tests that fail on the main branch still fails here) |
Added conflict analysis and week 9 updates