Skip to content

Conversation

BaldPulse
Copy link

Added conflict analysis and week 9 updates

@BaldPulse BaldPulse changed the title Week8 Strings Week8 Conflicts and New Feature May 24, 2022
@BaldPulse BaldPulse changed the title Strings Week8 Conflicts and New Feature Strings Week8 Conflicts and New Features May 24, 2022
@yalhessi
Copy link
Contributor

I've tried merging your feature and fixing some conflicts, but there's more work here to be done. Could you try fixing the issues with the tests and let me know how that goes.

@BaldPulse
Copy link
Author

I've tried merging your feature and fixing some conflicts, but there's more work here to be done. Could you try fixing the issues with the tests and let me know how that goes.

We'll start working on that as soon as possible!

@BaldPulse
Copy link
Author

I've tried merging your feature and fixing some conflicts, but there's more work here to be done. Could you try fixing the issues with the tests and let me know how that goes.

One smaller issue. Can you add .vscode to gitignore and delete the .vscode folder? It will make our lives a lot easier!

@KamranAlipour
Copy link
Contributor

I see 5 failings in your string tests, please take a look and try to resolve them.

@BaldPulse
Copy link
Author

I see 5 failings in your string tests, please take a look and try to resolve them.

now all the string tests pass, but we encountered some other bugs due to interactions with other groups. We have reported via email to the teaching team and the related groups.

@BaldPulse
Copy link
Author

I see 5 failings in your string tests, please take a look and try to resolve them.

Now merging does not introduce any new test fails. (tests that fail on the main branch still fails here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants