update from ground truth DO NOT NECESSARILY ACCEPT THIS PULL REQUEST #27
Conversation
| else: | ||
| prev_group = next_group = None | ||
|
|
||
|
|
There was a problem hiding this comment.
This is a bad hack added by P. Conrad for the CS8 Summer 2017 lab exam.
It is ok if it gets reverted. The purpose was so that students in earlier sections could not share their answers to the lab exam questions with students in later sections. That is, if the first four characters of the project are the magic value "EXAM", then all non admin users are prevented from seeing the "download" link on the view of the submission.
| return uid | ||
|
|
||
| # connect to ldap | ||
| ldap_conn = ldap.initialize(ldap_uri) |
There was a problem hiding this comment.
Looks like this is code added by Bryce to assist with running, for example, on AWS, outside of the context where the UCSB ldap server is directly accessible.
|
It looks like the ground truth is slightly behind this repository, with exception of the EXAM hack. With that in mind this PR probably isn't necessary. Glad to know there weren't too many other such updates though. Thanks for going through the exercise. |
2 participants
This is for REVIEW only... to compare ground truth on submit.cs.ucsb.edu with what's on the master branch of the repo.
We should carefully review all of this.