Address some dockerfile lint errors and warnings #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbardino
added
enhancement
jonasbardino
force-pushed
the
adjust/address-some-dockerfile-lint-errors-and-warnings
branch
from
6444508 to
ae8c2f3
Compare
|
There's a sort of related pending task of completely cleaning up after the |
…d in docker docs and pointed out by hadolint.
…`tini` we use the checksum of the binary that was released and gpg-signed by the author. Fix a FROM ... AS ... case mismatch as pointed out by docker compose.
…g image with package cache, etc. as pointed out by hadolint.
excessive image size. Properly anchor `*.key` to prevent option interference as recommended by ShellCheck (SC2035).
…e of the author for improved integrity assurance. We could in principle preserve the weaker checksum verification during ADD, but we disable it for the time being since gpg is sufficient and because `hadolint` does not yet support the `--checksum` argument to ADD.
…ly make a difference until we have cleaned up Dockerfiles enough to have nothing worse than warnings reported.
jonasbardino
force-pushed
the
adjust/address-some-dockerfile-lint-errors-and-warnings
branch
from
1390ab7 to
36c3294
Compare
jonasbardino
deleted the
adjust/address-some-dockerfile-lint-errors-and-warnings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added
hadolintAction should help identify various suboptimal or directly broken constructs in ourDockerfiles before they come back to bite us.One can also manually test e.g. with the docker version using: