Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shellcheck is a tool for finding problematic code in shell scripts, from syntax errors to subtle and non-intuitive pitfalls. It is also capable of automatically fixed some kinds of issues.
Eventually shellcheck will be enabled in the CI/CD checks (i.e. the linters) used by this repository. In order to ease that transition (and make your life easier!), this PR includes all code fixes that could be performed automatically.
None of these fixes have been tested - this pull request was generated by a script and should be reviewed very closely.
These changes make the shell scripts in this repository abide by the following shellcheck rules:
There were also warnings that could not be fixed automatically:
If any of these fixes/warnings are incorrect, shellcheck can be silenced by adding a line like
#shellcheck disable=<rule name>
immediately before the offending line (docs).Also, you can just sidestep this issue completely by adding a
.cicd-env
file to the root of this repository withVALIDATE_SHELL="false"
(reference). Please only do that as a last resort - linters are on your side!