Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit Husky, add prettier #89

Merged
merged 5 commits into from
Dec 1, 2021
Merged

fix: edit Husky, add prettier #89

merged 5 commits into from
Dec 1, 2021

Conversation

timothycpoon
Copy link
Contributor

Summary

Closes #68 and #87

  • Add prettier and run on pre-commit
  • Allow bad lint to be committed

Test Plan

Make a commit; prettier should now run as well. Changes which break lint should display an error but still commit correctly.

@netlify
Copy link

netlify bot commented Nov 29, 2021

✔️ Deploy Preview for teach-la-ts-react-starter ready!

🔨 Explore the source changes: b4108da

🔍 Inspect the deploy log: https://app.netlify.com/sites/teach-la-ts-react-starter/deploys/61a7af9bee745c00077394fe

😎 Browse the preview: https://deploy-preview-89--teach-la-ts-react-starter.netlify.app

@timothycpoon timothycpoon linked an issue Nov 29, 2021 that may be closed by this pull request
1 task
Copy link
Contributor

@reginawang3495 reginawang3495 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! thanks for doing this tim :))

@timothycpoon timothycpoon merged commit 73af545 into main Dec 1, 2021
@timothycpoon timothycpoon deleted the tpoon/cicd branch December 1, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: [husky]: Allow lint errors to be committed run prettier linting on pre-commit
2 participants