feat: disable prettier conflicts, change lint-staged to just lint-all

[reginawang3495]

Summary

• Remove prettier rules from eslint and stylelint since there are prettier and eslint/stylelint conflicts
• Removed lint-staged and replace with simple lint-fix on all files
• Added prettier to yarn lint

closes #113
closes #114

Test Plan

• made a change that should fail linting
• check to see that it fails
• check to see that it is automatically fixed with yarn lint-fix

[netlify]

✔️ Deploy Preview for teach-la-ts-react-starter ready!

🔨 Explore the source changes: e11e7a3

🔍 Inspect the deploy log: https://app.netlify.com/sites/teach-la-ts-react-starter/deploys/61f0782b7b655500071921a0

😎 Browse the preview: https://deploy-preview-119--teach-la-ts-react-starter.netlify.app

[doubleiis02]

oki i read through this all, seems like half the changes are just changes made by prettier itself, and the other half is code that implements prettier + its settings and then gets rid of stuff that prettier takes care of. i think it looks good

[matthewcn56]

I really like the idea of changing lint-staged to just fix all the linting progress overall as it would streamline the development process of fixing small errors on its own! However, I think in its current state, some es-lint and prettier rules are clashing, and could be solved with the es-lint prettier plugin as specified here and as specified in the review comment.

[matthewcn56]

Specifically adding in the 'comma-dangle': off clashes with prettier when linting and does not enforce that dangling commas should be there.

When using eslint with prettier, I think it would be better to add in the prettier plugin to our .eslintrc.js as specified here, and adding it at the end of our array of plugins.

And for things that are already covered by prettier like comma-dangle, instead of specifying off, we can just not mention the comma-dangle property at all, as comma-dangle off doesn't enforce dangling commas when linting within our pre-commit hook or yarn lint-fix command, but commenting it out does enforce it (when used in conjunction with the prettier es-lint plugin).

[reginawang3495]

kk sounds good, ty for the review!

[timothycpoon]

LGTM. Just a +1 to Matt’s comment. Some of the linting decisions were made w/ the editor’s situation In mind so it makes sense that some should be changed

[matthewcn56]

nice, looks like they don't conflict anymore!