Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaylin/making nav bar buttons interesting #411

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kaylin-chung
Copy link
Contributor

Fixes #375

@github-actions github-actions bot added the page Related to header/footer/things that show up on every page label Feb 25, 2024
Copy link
Collaborator

@jakobreinwald jakobreinwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Kaylin, everything looks great but I just have a few small changes and then we can get this merged in:

  • Can we increase the space between the Apply button and the rest of the page links
  • When dragging the page size from right to left to shrink, you'll see that before condensing the page links into the hamburger button, the Apply button gets stacked under the other ones. We want to switch to the condensed/mobile version before this happens, so you'll have to increase the size of the breakpoint.
  • Can we switch the color of the Apply button back to what it currently is on the HOTH website, just because it stands out a bit more.

Tyyy let me know if you have any questions

@jakobreinwald jakobreinwald self-requested a review March 10, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page Related to header/footer/things that show up on every page
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Update nav bar, look at hack website for reference
3 participants