Update get_appointment_groups, checks for creating new appointment groups #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… groups Fixes ucfopen#678 Two issues in one: 1. `canvas.get_appointment_groups()` returns an empty list for teachers because it defaults to "reservable", but instructors can't reserve, so the list is empty. Create a new param on the method that defaults to `reservable` but can be overridden. Update the docstring to note the change. 2. Update `create_appointment_group()` to take either a course ID or a `Course` object. Check that the `context_codes` key is present on the `appointment_group` dict before checking formatting. All tests passing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #679 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 74 74
Lines 3764 3769 +5
=========================================
+ Hits 3764 3769 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues in one:
canvas.get_appointment_groups()returns an empty list for teachers because it defaults to "reservable", but instructors can't reserve, so the list is empty. Create a new param on the method that defaults toreservablebut can be overridden. Update the docstring to note the change.Update
create_appointment_group()to take either a course ID or aCourseobject. Check that thecontext_codeskey is present on theappointment_groupdict before checking formatting.All tests passing.
Fixes #678