Update PaginatedList
#614
Merged
Update PaginatedList
#614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on ucfopen#605, `PaginatedList` could not process requests which return pagination info in the response body. This update checks for `Link` headers before checking the `meta` property in the response body.
Codecov Report
@@ Coverage Diff @@
## develop #614 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 72 72
Lines 3684 3691 +7
=========================================
+ Hits 3684 3691 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thetwam
requested changes
Apr 26, 2023
Contributor
Author
|
I've made the changes requested, all tests passing still. |
Thetwam
approved these changes
May 1, 2023
Member
Thetwam
left a comment
Thetwam
left a comment
There was a problem hiding this comment.
Looks like it's working well. Thanks for your contribution! 👍
Thetwam
added a commit
that referenced
this pull request
May 25, 2023
* Allow PaginatedList to use metadata for pagination (#614) * Update `PaginatedList` Based on #605, `PaginatedList` could not process requests which return pagination info in the response body. This update checks for `Link` headers before checking the `meta` property in the response body. * Update based on review * Update pag list test with no header no next meta to run properly. Update changelog. --------- Co-authored-by: Matthew Emond <me@ucf.edu> * New Quizzes (#612) * Begin adding coverage for New Quizzes (WIP) * Finish New Quizzes endpoints * Pin urllib3 to <2 for tests due to issue with requests-mock. jamielennox/requests-mock#228 * Course Create Discussion Attach Files #621 (#622) * Fix issue where Course.create_discussion_topic doesn't accept attachment files * Add file tests for create_discussion_topic * Delete method for course and group pages (#624) * method delete group and course pages, update tests * format fix * Add Caitlin to authors. Add contribution to changelog. Formwatting tweaks. --------- Co-authored-by: Matthew Emond <me@ucf.edu> * Remove Jesse as codeowner. Add Matthew Jones and Brian Bennett * Add support for Python 3.11 (#625) * markdown styling tweak to be in line with prettier's defaults * Bump version to 3.2.0 --------- Co-authored-by: Brian <brian.bennett2@gmail.com> Co-authored-by: Caitlin Fabian <89735646+Caitlin-Fabian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #605,
PaginatedListcould not process requests which return pagination info in the response body. This update checks forLinkheaders before checking themetaproperty in the response body.Resolves #605
Related: #565