Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix CI #649

Merged
merged 4 commits into from
Mar 21, 2019
Merged

Try to fix CI #649

merged 4 commits into from
Mar 21, 2019

Conversation

withsmilo
Copy link
Collaborator

@withsmilo withsmilo commented Mar 21, 2019 •
edited
Loading

I tried to fix CI because it is too unstable now.

  • Add a timer to multi_tenancy_test and kubernetes_namespace in the integration-tests
  • Fix an YAML warning
  • Check redis's status after deploying it
  • Replace read_namespaced_deployment_status of read_namespaced_deployment (Refer to Kubernetes model deployment permissions issue #597)

@withsmilo withsmilo self-assigned this Mar 21, 2019
@withsmilo withsmilo mentioned this pull request Mar 21, 2019
Closed
Fix the following YAML warning
69834c2 
```
YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  parsed = yaml.load(rendered)
```
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1805/
Test PASSed.

@withsmilo
Copy link
Collaborator Author

Jenkins test this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1806/
Test PASSed.

@withsmilo
Copy link
Collaborator Author

Jenkins test this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1807/
Test PASSed.

@withsmilo withsmilo requested a review from simon-mo March 21, 2019 05:59
@withsmilo
Copy link
Collaborator Author

@simon-mo : Please review this PR.

simon-mo
simon-mo approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for doing this.

@simon-mo simon-mo merged commit 847d6de into ucbrise:develop Mar 21, 2019
@withsmilo withsmilo deleted the try_fix_ci branch March 21, 2019 23:11
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 27, 2019
@rkooo567
Try to fix CI (ucbrise#649)
770324a 
* Add a timer to multi_tenancy_test

* Fix the following YAML warning

```
YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  parsed = yaml.load(rendered)
```

* Add a timer to kubernetes_namespace

* Check redis's status after deploying it
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 28, 2019
@rkooo567
Try to fix CI (ucbrise#649)
5a62020 
* Add a timer to multi_tenancy_test

* Fix the following YAML warning

```
YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  parsed = yaml.load(rendered)
```

* Add a timer to kubernetes_namespace

* Check redis's status after deploying it
rkooo567 pushed a commit to rkooo567/clipper that referenced this pull request Apr 28, 2019
@rkooo567
Try to fix CI (ucbrise#649)
54ee150 
* Add a timer to multi_tenancy_test

* Fix the following YAML warning

```
YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  parsed = yaml.load(rendered)
```

* Add a timer to kubernetes_namespace

* Check redis's status after deploying it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees

@withsmilo withsmilo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@withsmilo @AmplabJenkins @simon-mo