Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker version to be greater than 3.0 #515

Merged
merged 3 commits into from
Jun 12, 2018

Conversation

RehanSD
Copy link
Collaborator

@RehanSD RehanSD commented Jun 11, 2018

Docker versions less than 3.0 aren't adequate to properly run clipper.

@RehanSD RehanSD requested a review from simon-mo June 11, 2018 21:39
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@simon-mo
Copy link
Contributor

jenkins add to whitelist

@simon-mo
Copy link
Contributor

jenkins ok to test

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1586/
Test FAILed.

@RehanSD
Copy link
Collaborator Author

RehanSD commented Jun 11, 2018

jenkins retest this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1587/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1588/
Test PASSed.

@dcrankshaw dcrankshaw merged commit 062b968 into develop Jun 12, 2018
@dcrankshaw dcrankshaw deleted the rehan/docker_versioning branch June 12, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants