Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address k8s del_svc api change #470

Merged
merged 3 commits into from
Apr 18, 2018
Merged

Address k8s del_svc api change #470

merged 3 commits into from
Apr 18, 2018

Conversation

simon-mo
Copy link
Contributor

Fix Kubernetes Container Manager:

CHANGELOG (Kubernetes)
delete_namespaced_service() now takes an required body (delete option) parameter. 
Refactor service storage to remove registry wrapper kubernetes/kubernetes#59510

Spec:
https://github.com/kubernetes-client/python/blob/master/kubernetes/docs/CoreV1Api.md#delete_namespaced_service

Error like

  File "/Users/simonmo/Desktop/clipper/clipper/clipper_admin/clipper_admin/kubernetes/kubernetes_container_manager.py", line 393, in stop_all
    namespace='default', name=service_name)
TypeError: delete_namespaced_service() takes exactly 4 arguments (3 given)

will now go away.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1343/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1359/
Test PASSed.

Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1361/
Test PASSed.

@dcrankshaw dcrankshaw merged commit 4a6533a into develop Apr 18, 2018
@simon-mo simon-mo deleted the k8s_del_svc_fix branch April 20, 2018 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants