Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hard coded checkpoint prefix for TensorFlow deployer. #464

Merged
merged 2 commits into from
Apr 13, 2018
Merged

Fix hard coded checkpoint prefix for TensorFlow deployer. #464

merged 2 commits into from
Apr 13, 2018

Conversation

xunzhang
Copy link
Contributor

@xunzhang xunzhang commented Apr 8, 2018

No description provided.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@simon-mo
Copy link
Contributor

simon-mo commented Apr 8, 2018

jenkins test this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1317/
Test PASSed.

dcrankshaw
dcrankshaw approved these changes Apr 8, 2018
View reviewed changes
Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dcrankshaw
Copy link
Contributor

@xunzhang Thanks for the contribution! I'll get this merged as soon as the latest round of tests pass.

@dcrankshaw
Copy link
Contributor

jenkins ok to test

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1322/
Test FAILed.

@xunzhang
Copy link
Contributor Author

xunzhang commented Apr 9, 2018

I guess the Jenkins got some errors due to unclean CI environment? Since I also found this error for other RPs. @dcrankshaw Could you please take a look? Thanks.

@dcrankshaw
Copy link
Contributor

jenkins test this please

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1327/
Test PASSed.

@dcrankshaw dcrankshaw merged commit 4e775e3 into ucbrise:develop Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcrankshaw dcrankshaw dcrankshaw approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xunzhang @AmplabJenkins @simon-mo @dcrankshaw