Fix a bug that QueryFrontend adds a garbage to http response #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently QueryFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side. Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'. To fix it, '\n' must be removed from the http response.
|
Can one of the admins verify this patch? |
|
jenkins okay to test |
|
jenkins ok to test |
|
Test PASSed. |
|
@dcrankshaw : Thanks a lot! 👍 |
|
Thanks for the bug fix! |
gtfierro
pushed a commit
to gtfierro/clipper
that referenced
this pull request
Feb 27, 2018
…#415) Currently QueryFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side. Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'. To fix it, '\n' must be removed from the http response.
withsmilo
pushed a commit
to withsmilo/clipper
that referenced
this pull request
Oct 6, 2018
Currently ManagementFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side. Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'. To fix it, '\n' must be removed from the http response. I found the same bug in QueryFrontend and pull-requested it already. (ucbrise#415)
withsmilo
pushed a commit
to withsmilo/clipper
that referenced
this pull request
Mar 22, 2019
Currently ManagementFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side. Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'. To fix it, '\n' must be removed from the http response. I found the same bug in QueryFrontend and pull-requested it already. (ucbrise#415)
simon-mo
pushed a commit
that referenced
this pull request
Mar 28, 2019
* Fix a bug that ManagementFrontend adds a garbage to http response Currently ManagementFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side. Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'. To fix it, '\n' must be removed from the http response. I found the same bug in QueryFrontend and pull-requested it already. (#415) * Add a timer to container_test
rkooo567
pushed a commit
to rkooo567/clipper
that referenced
this pull request
Apr 27, 2019
…brise#582) * Fix a bug that ManagementFrontend adds a garbage to http response Currently ManagementFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side. Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'. To fix it, '\n' must be removed from the http response. I found the same bug in QueryFrontend and pull-requested it already. (ucbrise#415) * Add a timer to container_test
rkooo567
pushed a commit
to rkooo567/clipper
that referenced
this pull request
Apr 28, 2019
…brise#582) * Fix a bug that ManagementFrontend adds a garbage to http response Currently ManagementFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side. Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'. To fix it, '\n' must be removed from the http response. I found the same bug in QueryFrontend and pull-requested it already. (ucbrise#415) * Add a timer to container_test
rkooo567
pushed a commit
to rkooo567/clipper
that referenced
this pull request
Apr 28, 2019
…brise#582) * Fix a bug that ManagementFrontend adds a garbage to http response Currently ManagementFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side. Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'. To fix it, '\n' must be removed from the http response. I found the same bug in QueryFrontend and pull-requested it already. (ucbrise#415) * Add a timer to container_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently QueryFrontend sends ['http header' + 'content' + '\n'] as a http response to the outer side. Our team found some error cases occurred by wrong value(content.length()) of Content-Length in the 'http header'. To fix it, '\n' must be removed from the http response.