Explicitly install redis-server when building test container #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcrankshaw
reviewed
Feb 12, 2018
dockerfiles/ClipperTestsDockerfile
Outdated
| @@ -10,6 +10,9 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install --fix-missi | |||
| && apt-get update \ | |||
| && apt-get install -y docker-ce | |||
|
|
|||
| # install redis-server | |||
| RUN apt-get install -y redis-server | |||
There was a problem hiding this comment.
Instead of making a new layer why don't you just add it to the list of deps installed in lines 5-7
There was a problem hiding this comment.
I was confused by the install docker header, but it appears that we're doing more than installing docker in that section. Updated the comment and moved the installation into that layer.
|
Test PASSed. |
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.