Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced queues in RPC layer with MoodyCamel's lock-free queues #380

Merged
merged 5 commits into from
Feb 5, 2018
Merged

replaced queues in RPC layer with MoodyCamel's lock-free queues #380

merged 5 commits into from
Feb 5, 2018

Conversation

ryanhoque
Copy link
Contributor

addressing issue #335 - performance optimization using https://github.com/cameron314/concurrentqueue

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@dcrankshaw
Copy link
Contributor

jenkins ok to test

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/918/
Test FAILed.

Corey-Zumar
Corey-Zumar approved these changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@Corey-Zumar Corey-Zumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge when tests pass

@Corey-Zumar
Copy link
Contributor

jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/919/
Test FAILed.

@Corey-Zumar
Copy link
Contributor

@dcrankshaw Can you try formatting this? Yapf on my machine isn't catching the C++ format violations referenced by Jenkins.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/922/
Test FAILed.

@dcrankshaw
Copy link
Contributor

jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/925/
Test FAILed.

@ryanhoque
Copy link
Contributor Author

From what I can tell, the Jenkins test failed to build a test suite called 'rpc-test' because it couldn't find something called 'scala-compiler-2.11.8.jar' - not sure how to resolve this

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/939/
Test PASSed.

@Corey-Zumar Corey-Zumar merged commit 42fd27e into ucbrise:develop Feb 5, 2018
@dcrankshaw dcrankshaw mentioned this pull request Feb 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corey-Zumar Corey-Zumar Corey-Zumar approved these changes

Assignees
No one assigned
Labels
status: accepted type: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanhoque @AmplabJenkins @dcrankshaw @Corey-Zumar