Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default label placeholder when no label is provided #279

Merged
merged 1 commit into from
Sep 1, 2017
Merged

Remove default label placeholder when no label is provided #279

merged 1 commit into from
Sep 1, 2017

Conversation

dcrankshaw
Copy link
Contributor

@dcrankshaw dcrankshaw commented Sep 1, 2017 •
edited
Loading

I think we had already fixed #208 so this removes the now unnecessary placeholder label.

@dcrankshaw dcrankshaw self-assigned this Sep 1, 2017
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/674/
Test PASSed.

Corey-Zumar
Corey-Zumar approved these changes Sep 1, 2017
View reviewed changes
Copy link
Contributor

@Corey-Zumar Corey-Zumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Corey-Zumar Corey-Zumar merged commit 652aadb into ucbrise:develop Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corey-Zumar Corey-Zumar Corey-Zumar approved these changes

Assignees

@dcrankshaw dcrankshaw

Labels
status: needs review type: maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deploy_model with an empty label list causes an error
3 participants
@dcrankshaw @AmplabJenkins @Corey-Zumar