Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass by value where appropriate #252

Merged
merged 2 commits into from
Jul 13, 2017
Merged

Pass by value where appropriate #252

merged 2 commits into from
Jul 13, 2017

Conversation

nishadsingh1
Copy link

Makes benchmark script runnable; doesn't pass data in by reference to threads and then destroy it.

@nishadsingh1 nishadsingh1 self-assigned this Jul 13, 2017
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/570/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/571/
Test PASSed.

dcrankshaw
dcrankshaw approved these changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@dcrankshaw dcrankshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dcrankshaw dcrankshaw merged commit f0c51f9 into ucbrise:develop Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcrankshaw dcrankshaw dcrankshaw approved these changes

Assignees

@nishadsingh1 nishadsingh1

Labels
status: needs review type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nishadsingh1 @AmplabJenkins @dcrankshaw