Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units Overhaul #800

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Units Overhaul #800

merged 5 commits into from
Oct 3, 2023

Conversation

harrisonliew
Copy link
Contributor

@harrisonliew harrisonliew commented Sep 29, 2023

Follow-on to #798, some other small fixes:

  • Cap/time units should be derived from technology libs to calculate generated SDC constraints. Also do not override units in tools. See comment below for reasoning. Closes Eventually remove time unit from the tech json #519
  • get_db hports in SDC causes segfault - log an error
  • Genus can now also read power intent and insert cells
  • Take out annoying "not associated with a type" warning
  • Ignore decoding errors from stdout

Investigating if grid unit should also be removed and derived from tech LEF.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@harrisonliew harrisonliew added the Cadence Specific to a Cadence tool label Sep 29, 2023
@harrisonliew harrisonliew marked this pull request as draft September 29, 2023 23:53
@harrisonliew
Copy link
Contributor Author

harrisonliew commented Sep 29, 2023

@harrisonliew harrisonliew changed the title Genus Fixes Units Overhaul Sep 30, 2023
@harrisonliew harrisonliew marked this pull request as ready for review September 30, 2023 20:17
@harrisonliew harrisonliew added the SDC timing constraints label Sep 30, 2023
@harrisonliew harrisonliew added this pull request to the merge queue Oct 3, 2023
Merged via the queue into master with commit f06f7ca Oct 3, 2023
3 checks passed
@harrisonliew harrisonliew deleted the genus_fix branch October 3, 2023 05:13
@harrisonliew harrisonliew mentioned this pull request Oct 3, 2023
14 tasks
@dpgrubb13 dpgrubb13 mentioned this pull request Oct 5, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cadence Specific to a Cadence tool SDC timing constraints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventually remove time unit from the tech json
3 participants