-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/format_upgrade: handle multiple $refs #61
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- can we add some kind of a unit test that exercises the code with a dictionary that has a list of refs?
- does this change the object level API of the library? So if I have code that currently loads a dictionary and traverses its data structure - is something that was a string yesterday become a list today?
All the refs properties which generally refers to This has no impact on actual node schemas or definitions and already been implemented in GDC. Refer below pr for more details |
8f16cff
to
8633927
Compare
travis config update
8633927
to
e7590ad
Compare
This pull request introduces 1 alert when merging 464fa20 into 71db87f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging f71c345 into 71db87f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging cca1449 into 71db87f - view on LGTM.com new alerts:
|
Added support for parsing multiple refs (list) instead of single ref. this is due to format changes made & standardized across gen3 dictionaries.
Please dont merge the changes into master yet. it cant not be used until all the gen3 dictionaries are migrated to new format