Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/format_upgrade: handle multiple $refs #61

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ganjigajanan
Copy link

@ganjigajanan ganjigajanan commented May 20, 2020

Added support for parsing multiple refs (list) instead of single ref. this is due to format changes made & standardized across gen3 dictionaries.

Please dont merge the changes into master yet. it cant not be used until all the gen3 dictionaries are migrated to new format

Copy link
Contributor

@frickjack frickjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • can we add some kind of a unit test that exercises the code with a dictionary that has a list of refs?
  • does this change the object level API of the library? So if I have code that currently loads a dictionary and traverses its data structure - is something that was a string yesterday become a list today?

@ganjigajanan
Copy link
Author

All the refs properties which generally refers to _terms.yaml file and occasionally other yamls are converted to list instead of string to support multiple definitions a particular property can have. Earlier code travis tests assumed it to a single string and process. The change is to simply convert it to list if not it already is and parse them.

This has no impact on actual node schemas or definitions and already been implemented in GDC.

Refer below pr for more details
NCI-GDC/gdcdictionary@d4758e7

@lgtm-com
Copy link

lgtm-com bot commented May 22, 2020

This pull request introduces 1 alert when merging 464fa20 into 71db87f - view on LGTM.com

new alerts:

  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented May 22, 2020

This pull request introduces 1 alert when merging f71c345 into 71db87f - view on LGTM.com

new alerts:

  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented May 22, 2020

This pull request introduces 1 alert when merging cca1449 into 71db87f - view on LGTM.com

new alerts:

  • 1 for Syntax error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants