Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Adopt new psqlgraph (and py2neo) #54

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

themarcelor
Copy link
Contributor

@themarcelor themarcelor commented Mar 30, 2021

We need a new psqlgraph version that removes the py2neo dependency.

Improvements

  • New psqlgraph

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

pyproject.toml Outdated
@@ -22,7 +22,7 @@ openpyxl = "2.6.4"
rstr = "2.2.6"
requests = "^2.18.0"
dictionaryutils = "^3.0.2"
py2neo = {url = "https://cdistest-public-test-bucket.s3.amazonaws.com/py2neo-py2neo-2.0.8.tar.gz"}
psqlgraph = "^3.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do ~3.0 if we want to catch any patch version updates, but not a big deal. Either way we'd have to regenerate the lock if we bumped the dep 😛

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea 🤯 !

Copy link
Contributor

@williamhaley williamhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :shipit:

@themarcelor themarcelor merged commit 2d8bf19 into master Mar 31, 2021
@themarcelor themarcelor deleted the chore/adopt_new_psqlgraph branch March 31, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants