Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXP-4535 Fix/get access button #625

Merged
merged 10 commits into from
Dec 4, 2019
Merged

PXP-4535 Fix/get access button #625

merged 10 commits into from
Dec 4, 2019

Conversation

mfshao
Copy link
Collaborator

@mfshao mfshao commented Dec 2, 2019 •
edited
Loading

This PR fulfills https://ctds-planx.atlassian.net/browse/PXP-4535

A new hideGetAccessButton field is added to portal config, in the dataExplorerConfig section, the default value is false.

If hideGetAccessButton is ture, Get Access buttons is removed from data explorer.

If hideGetAccessButton is false and if no getAccessButtonLink has been specified in portal config, Get Access buttons is disabled with a tooltip saying “Coming soon“

Deployed in https://mingfei.planx-pla.net/ (with no getAccessButtonLink and hideGetAccessButton in portal config)

New Features

  • New hideGetAccessButton field to hide the Get Access button in data explorer

Improvements

  • Get Access button in data explorer will be disabled and showing a tooltip if there is no getAccessButtonLink in portal config and hideGetAccessButton is missing or false
  • Appearance update for data explorer top message bar

em-ingram
em-ingram approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@em-ingram em-ingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mfshao mfshao merged commit b87df2c into master Dec 4, 2019
@mfshao mfshao deleted the fix/get-access-button branch December 4, 2019 17:37
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@em-ingram em-ingram em-ingram approved these changes

@ZakirG ZakirG Awaiting requested review from ZakirG

@qingyashu qingyashu Awaiting requested review from qingyashu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfshao @em-ingram