Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Travis CI and pre-commit framework to check shell scripts #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brlin-tw
Copy link
Contributor

No description provided.

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
@oSoMoN
Copy link
Member

oSoMoN commented May 29, 2018

Thanks for your work on this!

If we are going to merge this, we should create a dedicated travis-ci account for snapcraft-desktop-helpers, or maybe re-use an existing one used by other ubuntu projects (is there one?).

I'm not familiar with pre-commit, do we really need this framework to just run shellcheck on the shell scripts? Or do you envision that there are other useful existing pre-commit hooks that we could add to the CI logic in the future?

@brlin-tw
Copy link
Contributor Author

brlin-tw commented May 29, 2018

Oops I did not notice that the badge is actually bound with my forked repo, I've dropped the badge commit.

@brlin-tw
Copy link
Contributor Author

brlin-tw commented May 29, 2018

do we really need this framework to just run shellcheck on the shell scripts?

I once used manually crafted scripts to check the bash scripts, but pre-commit surpasses all my expectations so recently I dropped all of them in favor of pre-commit.

Or do you envision that there are other useful existing pre-commit hooks that we could add to the CI logic in the future?

Please check out the Supported Hooks, I'm sure there are many hooks we can use with the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants