Makefile: Honour CC, CFLAGS #119
Conversation
This patch honours CC, CFLAGS environment variables when building src/bindtextdomain.c. This allows snaps to override it with different toolchains. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
|
I wonder if that's really desirable. If a snap build uses custom flags (or even a different compiler) that trigger an obscure compiler bug, the risk is that two snaps that use the same helper will behave differently. Also, if you change the value of CC, there's no guarantee the custom compiler will be installed with the build-packages. |
Well, one can always force using the bugless compiler in these cases. The patch's is created upon the fact that I'm not sure that the desktop-helper will work properly with other parts as my package requires GCC >6 instead of the pre-installed version of GCC5 provided by Ubuntu 16.04 so I simply switch all of the toolchains that are used to build the parts, which, without this patch, |
This patch honours CC, CFLAGS environment variables when building
src/bindtextdomain.c.
This allows snaps to override it with different toolchains.
~~This patch is NOT tested~, please review.
UPDATE: This patch has been verified to build successfully in my LXD container.
Signed-off-by: 林博仁(Buo-ren Lin) Buo.Ren.Lin@gmail.com