Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of services #259

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

List of services #259

wants to merge 17 commits into from

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Mar 9, 2025

Summary

This pull request includes multiple improvements, new features, and fixes related to core service management and overall code maintenance.

Changes

  • Fixes:

    • Improved calls of str_to_bool by removing unnecessary == 1 postfixes.
    • Removed references to async task handles after completion to prevent memory leaks.
  • Features:

  • Refactoring:

    • Updated setup function to return service subscriptions, enabling proper cleanup when services stop.

Impact

These changes improve service management, optimize memory usage, enhance code readability, and maintain test integrity.

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 79.11857% with 199 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ubo_app/service_thread.py 79.87% 63 Missing ⚠️
ubo_app/error_handlers.py 7.14% 26 Missing ⚠️
ubo_app/main.py 0.00% 16 Missing ⚠️
ubo_app/store/settings/services.py 78.46% 14 Missing ⚠️
ubo_app/store/core/reducer.py 77.08% 11 Missing ⚠️
ubo_app/store/main.py 81.13% 10 Missing ⚠️
ubo_app/setup.py 38.46% 8 Missing ⚠️
ubo_app/services/080-docker/docker_container.py 22.22% 7 Missing ⚠️
ubo_app/services/080-docker/setup.py 50.00% 6 Missing ⚠️
ubo_app/store/settings/reducer.py 71.42% 6 Missing ⚠️
... and 16 more
Flag Coverage Δ
ubuntu-latest 57.55% <79.11%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ubo_app/colors.py 100.00% <100.00%> (ø)
ubo_app/constants.py 100.00% <100.00%> (ø)
ubo_app/menu_app/menu.py 92.30% <100.00%> (+2.30%) ⬆️
ubo_app/menu_app/menu_central.py 68.03% <ø> (-1.50%) ⬇️
ubo_app/menu_app/menu_footer.py 94.73% <100.00%> (+0.23%) ⬆️
ubo_app/menu_app/menu_header.py 68.18% <100.00%> (+1.91%) ⬆️
ubo_app/menu_app/menu_notification_handler.py 26.00% <100.00%> (ø)
ubo_app/service.py 92.30% <100.00%> (-4.57%) ⬇️
ubo_app/services/000-audio/ubo_handle.py 100.00% <100.00%> (ø)
ubo_app/services/000-display/ubo_handle.py 100.00% <100.00%> (ø)
... and 74 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolate threads and avoid propagation of their crash Implement services service
1 participant