Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(display): decrease baudrate from 70,000,000 to 60,000,000 to avoid residual noise on the display - closes #236 #258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Mar 8, 2025

I think the residual pixel noise was happening because we assumed higher bandwidth than what the lcd has in reality, I decreased it and couldn't reproduce it on my Pi 4 anymore.

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ubo_app/main.py 0.00% 1 Missing ⚠️
Flag Coverage Δ
ubuntu-latest 56.76% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ubo_app/constants.py 100.00% <100.00%> (ø)
ubo_app/display.py 75.00% <100.00%> (ø)
ubo_app/main.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@zytegalaxy zytegalaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I suggest we go ahead and merge this and in the meantime, I will keep an eye on residual noise issues after merge and see if it ever comes back. We can play with the baud rate if it needs further adjustments later.

@sassanh
Copy link
Collaborator Author

sassanh commented Mar 12, 2025

I suggest we go ahead and merge this and in the meantime, I will keep an eye on residual noise issues after merge and see if it ever comes back.

It would be nice if we could test it before merging.

@zytegalaxy
Copy link
Collaborator

I suggest we go ahead and merge this and in the meantime, I will keep an eye on residual noise issues after merge and see if it ever comes back.

It would be nice if we could test it before merging.

sure I will test it. Since this issue doesn't appear all the time, we should accept the test result with a grain of salt until this will be tested on more devices over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants