-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(display): decrease baudrate from 70,000,000 to 60,000,000 to avoid residual noise on the display - closes #236 #258
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
0ebc0c9
to
a1f6734
Compare
a1f6734
to
1a98b5a
Compare
…d residual noise on the display - closes #236
1a98b5a
to
0a6f43d
Compare
0a6f43d
to
81c98d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I suggest we go ahead and merge this and in the meantime, I will keep an eye on residual noise issues after merge and see if it ever comes back. We can play with the baud rate if it needs further adjustments later.
It would be nice if we could test it before merging. |
sure I will test it. Since this issue doesn't appear all the time, we should accept the test result with a grain of salt until this will be tested on more devices over time. |
I think the residual pixel noise was happening because we assumed higher bandwidth than what the lcd has in reality, I decreased it and couldn't reproduce it on my Pi 4 anymore.