-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core,audio,display,keypad,sensors): read and check content of eeprom to determine if a device/service should be initialized or not - closes #223, #closes #249 #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like the LCD detection logic is inverse. Can you please check that? see my inline comment.
ee9efd6
to
98505a4
Compare
98505a4
to
b1b9ffc
Compare
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
b1b9ffc
to
84b2afa
Compare
84b2afa
to
02b6df8
Compare
This pull request adds
get_eeprom_data()
which reads the content of the eeprom memory and returns it as aTypedDict
.Initialization of audio, rgb-ring, display, sensors and keypad, are now conditional based on whether the expected model of the required module is reported to be installed on the device.