Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core,audio,display,keypad,sensors): read and check content of eeprom to determine if a device/service should be initialized or not - closes #223, #closes #249 #257

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Mar 8, 2025

This pull request adds get_eeprom_data() which reads the content of the eeprom memory and returns it as a TypedDict.

Initialization of audio, rgb-ring, display, sensors and keypad, are now conditional based on whether the expected model of the required module is reported to be installed on the device.

…f eeprom to determine if a device/service should be initialized or not - closes #223, #closes #249
Copy link
Collaborator

@mehrdadfeller mehrdadfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like the LCD detection logic is inverse. Can you please check that? see my inline comment.

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 73.04965% with 38 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ubo_app/utils/eeprom.py 85.22% 13 Missing ⚠️
ubo_app/display.py 37.50% 10 Missing ⚠️
ubo_app/services/000-audio/audio_manager.py 44.44% 10 Missing ⚠️
ubo_app/services/000-keypad/setup.py 25.00% 3 Missing ⚠️
ubo_app/services/040-sensors/setup.py 80.00% 2 Missing ⚠️
Flag Coverage Δ
ubuntu-latest 56.56% <73.04%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ubo_app/services/040-rgb-ring/setup.py 53.84% <100.00%> (-46.16%) ⬇️
ubo_app/store/update_manager/types.py 100.00% <100.00%> (ø)
ubo_app/services/040-sensors/setup.py 82.50% <80.00%> (-6.39%) ⬇️
ubo_app/services/000-keypad/setup.py 28.68% <25.00%> (+0.11%) ⬆️
ubo_app/display.py 75.00% <37.50%> (-3.44%) ⬇️
ubo_app/services/000-audio/audio_manager.py 42.00% <44.44%> (-3.06%) ⬇️
ubo_app/utils/eeprom.py 86.17% <85.22%> (+32.32%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sassanh sassanh enabled auto-merge (rebase) March 11, 2025 08:17
@sassanh sassanh merged commit 94bd61b into main Mar 11, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants