Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react implementation of interactive web-ui #246

Merged
merged 15 commits into from
Mar 7, 2025
Merged

react implementation of interactive web-ui #246

merged 15 commits into from
Mar 7, 2025

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Feb 27, 2025

Summary

This PR introduces multiple improvements and fixes across different areas of the project, with a major focus on enhancing the Web-UI service, refining system behavior, and addressing known issues.

Key Changes

Bug Fixes:

  • Fixed an issue where image sizes were too large for the lite version.
  • Ensured avahi-daemon restarts properly after setting the hostname in ubo-system.
  • Fixed missing input field when fields and pattern properties are absent in the InputDescription.

New Features:

  • Implemented a React-based frontend for the web-ui service.
  • Added keypad button layout and swipe gesture handling in the web application.
  • Introduced dark mode support and color scheme switching buttons for the web application.

Refactors & Enhancements:

  • Web-UI Dialogs: Updated input dialogs to use MUI dialogs for a more consistent UI.
  • WebAudio Integration: Migrated audio playback to WebAudio API and introduced an unmute button.
  • Voice System Input Handling: Refactored access_key input of the voice service to leverage the new InputDescription's fields property.
  • Code Quality Improvements: Added linting and formatting rules to the web application codebase.
  • GRPC code generator: Add support for Python's native set data structure and split code into multiple files to improve maintainability.

This PR significantly improves the Web-UI experience while addressing critical system issues and refining the codebase. 🚀

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 45.38153% with 136 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ubo_app/services/090-web-ui/setup.py 18.66% 61 Missing ⚠️
ubo_app/services/080-docker/docker_container.py 22.50% 31 Missing ⚠️
ubo_app/services/080-docker/reducer.py 11.53% 23 Missing ⚠️
ubo_app/services/080-docker/docker_image.py 33.33% 6 Missing ⚠️
ubo_app/services/080-docker/docker_composition.py 54.54% 5 Missing ⚠️
ubo_app/services/010-voice/setup.py 20.00% 4 Missing ⚠️
ubo_app/services/080-docker/docker_images.py 78.57% 3 Missing ⚠️
ubo_app/store/services/voice.py 60.00% 2 Missing ⚠️
ubo_app/system/system_manager/main.py 0.00% 1 Missing ⚠️
Flag Coverage Δ
ubuntu-latest 56.54% <45.38%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ubo_app/constants.py 100.00% <100.00%> (ø)
ubo_app/display.py 78.43% <100.00%> (+2.34%) ⬆️
ubo_app/services/000-audio/reducer.py 54.05% <ø> (ø)
...vices/030-wifi/pages/create_wireless_connection.py 37.50% <ø> (ø)
ubo_app/services/050-users/setup.py 68.67% <ø> (+1.23%) ⬆️
ubo_app/services/080-docker/menus.py 38.29% <ø> (-2.52%) ⬇️
ubo_app/services/080-docker/setup.py 44.70% <100.00%> (+5.74%) ⬆️
ubo_app/side_effects.py 52.74% <ø> (ø)
ubo_app/store/input/types.py 100.00% <100.00%> (ø)
ubo_app/store/services/audio.py 100.00% <100.00%> (ø)
... and 12 more
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sassanh sassanh force-pushed the main branch 6 times, most recently from 436bd97 to e786876 Compare February 27, 2025 10:51
…stead of jinja-rendered interface) and add action buttons for all status reported by server - closes #224
Copy link
Collaborator

@zytegalaxy zytegalaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this PR! Please go ahead and merge if you don't have any pending commits.

@sassanh sassanh merged commit c56cfe9 into main Mar 7, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants