Solidity imported libraries should have a version

[eugenioclrc]

Currently its not clear what version of used libraries the protocolo is using;
https://github.com/ubiquity/ubiquity-dollar/blob/development/.gitmodules

What should be done:

1. Remove tags (because they are not working in git submodules) and add branch names to git submodules (perhaps this requires some code refactoring, make sure that libs are also updated after settings branch names)
2. Remove duplicate entries in git submodules

[0x4007]

@rndquu @zgorizzo69 any inputs on this?

[eugenioclrc]

@rndquu @zgorizzo69 any inputs on this?

I could take it but first I want to hear your opinions

[rndquu]

@eugenioclrc

So in the end in git submodules we will have smth similar to:

[submodule "packages/contracts/lib/openzeppelin-contracts"]
	path = packages/contracts/lib/openzeppelin-contracts
	url = https://github.com/OpenZeppelin/openzeppelin-contracts
        branch = release-v4.9
[submodule "packages/contracts/lib/forge-std"]
	path = packages/contracts/lib/forge-std
	url = https://github.com/foundry-rs/forge-std
	branch = v1

Questions:

1. Is the above example correct?
2. This way we will no more have the ability to use forge update but use only git submodule update --remote, right? (in this case it would be nice to have a separate script in package.json like forge:update that uses git submodule update --remote under the hood)

Also some dependencies may be broken after such an update so perhaps this task also requires some refactoring.

Overall the issue looks good.

[eugenioclrc]

@eugenioclrc

So in the end in git submodules we will have smth similar to:

[submodule "packages/contracts/lib/openzeppelin-contracts"]
	path = packages/contracts/lib/openzeppelin-contracts
	url = https://github.com/OpenZeppelin/openzeppelin-contracts
        branch = release-v4.9
[submodule "packages/contracts/lib/forge-std"]
	path = packages/contracts/lib/forge-std
	url = https://github.com/foundry-rs/forge-std
	branch = v1

Questions:

1. Is the above example correct?
2. This way we will no more have the ability to use forge update but use only git submodule update --remote, right? (in this case it would be nice to have a separate script in package.json like forge:update that uses git submodule update --remote under the hood)

Also some dependencies may be broken after such an update so perhaps this task also requires some refactoring.

Overall the issue looks good.

1. Yes, you are correct
2. i think that instead of forge update a simple forge install should be enough, and if you want to update the lib you just change the branch, another suggestion could be using package.json to handle the libraries. This is an example of a project using that config; package.json#L25-L31

[rndquu]

another suggestion could be using package.json to handle the libraries

I think setting branch name in git submodules should be enough at the current project stage.

Migrating to package.json has some drawbacks:

1. Not a "native" way to install dependencies in foundry framework
2. New devs who come to the project would expect dependencies in the lib folder (because this is a foundry project)
3. Something should definitely be broken (some CI actions or scripts) if we remove the lib folder with git submodules