PR: bug fixes & improvements #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpc-handler failure being handled by useRpcHandler
useRpcHandler is now providing decent provider
will not work on CF worker without skipFetchSetup=true
|
being used by both frontend & backend
to show available payment cards
to view available payment cards
so that it works for both sandbox and production
Unused devDependencies (4)
|
…into development
|
Now env vars & secretes are pushed from Github. We don't need to manually add env vars & secrets in cloudflare. But we need to add 2 new secret to this Github Repository now.
I will send you their values in telegram to add to this repository. @0x4007 |
|
I added them to the organization secrets just in case we need elsewhere! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #366
QA: Preview link: EresDevOrg#1 (comment)
The preview link of the QA shows a 30$ permit link on preview deployment, which uses Reloadly sandbox. This should meet most of the UI changes required by issues specs.
QA: Minted payment card
to show minting is working smoothly after changes.
How to test?
The deliverable is a combination of multiple different issues. If you follow each issue, it should be easy to test using preview link or source code.
Some parts of the issue specs are ignored by this PR because the specs seem useful but their implementation were causing more trouble than it was solving. They were:
The plan was to move all backend, frontend, and shared env vars to one file as they currently exists in .env, wrangler.toml, and shared/constants.ts.
But they are needed by different systems at different time. Moving them to .env was requiring another system to regenrate them at right time in the right system. So, this was skiped as current implementation is simpler.
There are many config files in the main directory of the repository. Moving them to /configs was interesting idea but some packages were causing hard to fix issues with this as they were expecting configs in the main directory. Plus, in the configs, there are paths to other files which were requiring more attention and debugging and paths were becoming odd. So, this was skipped.