Allow proto files to have a separate configurable idl root #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows proto files to have a separate configurable idl root in PackageHelperOptions. It adds one field of ProtoRelIdlRootDir in PackageHelperOptions. In case ProtoRelIdlRootDir is not specified, use RelIdlRootDir, if RelIDlRootDir is not set, use "./idl" as default.
Added test cases in package_test.go and client_test.go to cover the code changes. Also modified one of the examples to have protos live under "./bazel-out/idl"
It is used to create newGRPCClientSpec. This change doesn't break existing Thrift or Proto codegen, as for the existing code ProtoRelIdlRootDir is empty, it defaults to the current RelIdlRootDir.
This change will resolve issues in generating services and endpoints when deep dependencies includes both thrift and proto.