Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow query params to be marshaled into set #617

Merged
merged 3 commits into from
Aug 7, 2019
Merged

Conversation

argouber
Copy link
Contributor

@argouber argouber commented Aug 6, 2019

Currently we only support lists. This adds support for set

With this change, we are allowing repeated query params to be mapped into a set
Currently they can only be added to a list.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 67.869% when pulling 01f3034 on argo/sets_in_query into e6898db on master.

Copy link
Contributor

@rpatali rpatali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@argouber argouber merged commit 5a3df0d into master Aug 7, 2019
smb158 pushed a commit that referenced this pull request Aug 15, 2019
* Allow query params to be marshaled into thrift set

With this change, we are allowing repeated query params to be mapped into a set
Currently they can only be added to a list.
@argouber argouber deleted the argo/sets_in_query branch November 8, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants