refactor(cachekey): move internal/cachekey to core/cachekey to make it importable#213
Merged
Conversation
Users need to be able to import the cache key helpers, so the package can no longer live under the repo-private internal/ tree.
goimports groups github.com/uber/tango imports alphabetically; core/cachekey was appended out of order in three files.
xytan0056
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache key helpers are used in orchestrator implementations, so users implementing their own orchestrator cannot import cachekey because it's under internal. Move the package to core/ to make it importable.
Test Plan
CI
Issue