Upgrading the repo dependencies and tooling to current android standards #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a new workflow with jdk 17 and updating maven publish command
psteiger
reviewed
Feb 20, 2024
psteiger
reviewed
Feb 20, 2024
| } | ||
| } | ||
|
|
||
| pluginManager.withPlugin("com.android.library") { |
There was a problem hiding this comment.
Have you considered the includedBuilds approach for configuring the modules? As we did in RIBs
There was a problem hiding this comment.
I haven't looked at how it's done in RIBs repo so not sure what you mean.
What's the benefit? I can check it later and update the gradle file if needed
psteiger
reviewed
Feb 20, 2024
core-android/src/main/java/com/uber/sdk/android/core/auth/SsoDeeplink.java
Outdated
Show resolved
Hide resolved
core-android/src/test/java/com/uber/sdk/android/core/RobolectricTestBase.java
Show resolved
Hide resolved
core-android/src/test/java/com/uber/sdk/android/core/auth/LoginButtonTest.java
Outdated
Show resolved
Hide resolved
rides-android/src/test/java/com/uber/sdk/android/rides/RobolectricTestBase.java
Show resolved
Hide resolved
psteiger
approved these changes
Feb 20, 2024
lalwani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo was not updated for several years so this diff contains a bunch of upgrades to modernize the repo.