Repository navigation
Conversation
Interface addresses come back as *net.IPNet, whose String() is in CIDR notation, so net.ParseIP returned nil and every local IP was skipped. Read the IP from the address value instead.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #699
getLocalNamesparsed each interface address withnet.ParseIP(addr.String()).net.Interface.Addrs()returns*net.IPNet, whoseString()is CIDR (127.0.0.1/8), so the parse returned nil and every local IP was skipped. Only the hostname ended up in the set, and a build-index listed by IP did not strip itself.This reads the IP from the
*net.IPNet/*net.IPAddrvalue instead. IPv6 addresses are still skipped by the existingTo4()check.Note: the old comment said "non-loopback ips", but the code never filtered loopback. With this change loopback addresses are included, so a
127.0.0.1:<port>entry for the same port is stripped too. I updated the comment to match. Happy to skip loopback instead if that was the intent.Tested on macOS:
go test -race --tags unit ./lib/hostlist/... ./build-index/...passesTestStripLocalRemovesLocalIPfails on main (127.0.0.1:80is kept) and passes with the fixgolangci-lint run ./lib/hostlist/...: 0 issues