Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination support for gcs backend #184

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Add pagination support for gcs backend #184

merged 1 commit into from
Jul 2, 2019

Conversation

rmalpani-uber
Copy link
Contributor

Pagination support
Mock based test case for pagination

rmalpani-uber
rmalpani-uber commented Jul 1, 2019
View reviewed changes
Copy link
Contributor Author

@rmalpani-uber rmalpani-uber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will post a new diff with the comment resolved

lib/backend/gcsbackend/client.go Outdated Show resolved Hide resolved
@ASankaran ASankaran mentioned this pull request Jul 1, 2019
Merged
@yiranwang52 yiranwang52 merged commit 0e9469e into uber:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASankaran ASankaran ASankaran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmalpani-uber @ASankaran @yiranwang52