cmake: declare project() ASAP after cmake_minimum_required() & use c_std_99 compile feature
#641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's a hard requirement to compile at least with C99, so it shouldn't be delegated to an optional toolchain file
isaacbrodsky
approved these changes
Aug 17, 2022
|
Since this is a cleanup PR I'll plan to merge after v4.0.0 is released. |
ajfriend
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project()must be declarated aftercmake_minimum_required()c_std_99compile feature rather than an optional toolchain file. Toolchain file is for consumers, not for hard requirements of a project.