Add polygonToCellsNoHoles fuzzer #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfellis
approved these changes
Jan 17, 2022
nrabinowitz
approved these changes
Jan 22, 2022
| geoPolygon.numHoles = 0; | ||
| geoPolygon.holes = NULL; | ||
| geoPolygon.geoloop.numVerts = numVerts; | ||
| geoPolygon.geoloop.verts = (LatLng *)(data + 1); |
There was a problem hiding this comment.
For my info - why + 1? Oh, because the first uint_8 is the res? Might be worth a comment.
I imagine that most fuzzer runs would error quickly on an invalid res here, and never exercise the polyfill...
There was a problem hiding this comment.
This is still better than fuzzerPoylgonToCells.c which is very difficult for the fuzzer to make progress on; here it only needs to guess one byte correctly (polygonToCells actually takes an int but I don't think that's quite as relevant) which I believe is very doable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #553. This adds a second fuzzer for polygonToCells which does not require the fuzzer to guess the correct number of cells.