Merged
Conversation
nrabinowitz
approved these changes
Mar 11, 2026
Collaborator
nrabinowitz
left a comment
nrabinowitz
left a comment
There was a problem hiding this comment.
Looks good, just a small perf note. If there's a reason to use flatten it would be good to have a test to demonstrate.
Comment on lines
+132
to
+134
| return flatten( | ||
| geometry.coordinates.map(point => [h3.latLngToCell(point[1], point[0], resolution)]) | ||
| ); |
Collaborator
There was a problem hiding this comment.
Is there any reason to flatten this, rather than just doing
Suggested change
| return flatten( | |
| geometry.coordinates.map(point => [h3.latLngToCell(point[1], point[0], resolution)]) | |
| ); | |
| return geometry.coordinates.map(point => h3.latLngToCell(point[1], point[0], resolution)); |
Collaborator
Author
There was a problem hiding this comment.
I used flatten because it also deduplicates values, it is true there are unnecessary copies in that function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12
Note: While looking at this I noticed the options may not get passed down correctly for FeatureCollections.
LineStrings could be a possible future improvement.