Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix in Dragonnet: Adam parameter name lr depreciation #617

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

huigangchen
Copy link
Collaborator

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

For tensorflow>=2.3 lr parameter is depreciated in Adam optimizer. It produces nan result in Dragonnet. The fix is to use the updated name learning_rate and I am able to reproduce the result in the example notebook again.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@huigangchen huigangchen changed the title Huigang test Bug Fix in Dragonnet: Adam parameter name lr depreciation Apr 28, 2023
Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeongyoonlee jeongyoonlee merged commit 7ef4941 into master Jul 7, 2023
@jeongyoonlee jeongyoonlee deleted the huigang_test branch July 7, 2023 20:59
jeongyoonlee added a commit that referenced this pull request Jul 8, 2023
* Fixed a bug in Dragonnet to support TF>=2.4
* fix lint error

---------

Co-authored-by: Jeong-Yoon Lee <jeongyoon.lee1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants