Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update methodology.rst #568

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Update methodology.rst #568

merged 1 commit into from
Nov 10, 2022

Conversation

joel-mcmurry
Copy link
Contributor

Proposed changes

Changed language in documentation of S-learner to reflect the fact that mean conditional response $\mu(x,w)$ is defined under "treatment," not under "treatment effect." Treatment effect is estimated as difference $\hat{\mu}(x,1) - \hat{\mu}(x,0)$. See (Kunzel et al 2019, pp 3-4).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

mean conditional response \mu is defined under "treatment," not under "treatment effect." changed language to reflect this
Copy link
Collaborator

@t-tte t-tte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@jeongyoonlee jeongyoonlee merged commit 7050c74 into uber:master Nov 10, 2022
@joel-mcmurry joel-mcmurry deleted the patch-1 branch November 10, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants